skpro icon indicating copy to clipboard operation
skpro copied to clipboard

[ENH] Poisson distribution

Open fkiraly opened this issue 1 year ago • 3 comments

This PR adds a Poisson distribution.

The implementation is rudimentary, aiming at the minimum methods to be implemented.

The intention is to use this example to develop framework capability for discrete and mixed distributions.

fkiraly avatar Mar 30 '24 22:03 fkiraly

FYI @julian-fong, @shreesham07, @nilesh05apr, this should be useful for all of you?

Apologies if you've already started implementing something, @nilesh05apr, I just thought it would be useful to see if any framework issues arise, since this would be the first distribution with a discrete subdomain of the reals.

I've also opened a design issue here, regarding handling of pdf vs pmf: https://github.com/sktime/skpro/issues/229

fkiraly avatar Mar 31 '24 16:03 fkiraly

Yes, this distribution should be helpful when implmenting _predict_proba for future estimators

julian-fong avatar Apr 01 '24 00:04 julian-fong

reviews are appreciated 😃

fkiraly avatar Apr 01 '24 00:04 fkiraly