skbase icon indicating copy to clipboard operation
skbase copied to clipboard

[ENH] Introduce Serialization Support

Open achieveordie opened this issue 1 year ago • 2 comments

Part of #145 - Introduces serialization functionality.

Currently, this is a direct port from the functionality we have in sktime. I'll iteratively improve the code as per requirements and inputs.

What does this implement/fix? Explain your changes.

  • [x] Port serialization methods (load as a standalone function, save as BaseObject method) from sktime
  • [ ] Add tests to ensure the functionalities added work properly and are consistent with the expected behaviour.
  • [ ] Improve/add code to ensure this functionality can be generally applied and extended.

Does your contribution introduce a new dependency? If yes, which one?

None

What should a reviewer concentrate their feedback on?

  • since bandit complains about the usage of pickle. I've excluded two tests (import and load) and will add a warning in load's docstring regarding it. We should try to find safer alternatives to replace it in the future.
  • What improvements should we bring to the current code? Some nice-to-have functionalities etc

Any other comments?

PR checklist

For all contributions
  • [x] I've reviewed the project documentation on contributing
  • [ ] I've added myself to the list of contributors.
  • [x] The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions
  • [ ] Unit tests have been added covering code functionality
  • [x] Appropriate docstrings have been added (see documentation standards)
  • [ ] New public functionality has been added to the API Reference

achieveordie avatar Apr 02 '23 07:04 achieveordie