skshetry

Results 292 comments of skshetry

Should `make_summary` be called `write_summary` or just `log_summary`?

> Basically it would be a generalized GitRegistry.from_repo(r), including the remote repos. That's what I meant by `open_repo`, that's how we use in `dvc` with `Repo.open()` that always gives you...

Closing, we don't use `gitpython` for cloning these days.

@dberenbaum, we have the support for this in upstream now.

Also there have been questions about `--untracked-files` being inconsistent with rest of the flags (https://github.com/iterative/dvc/pull/7943#discussion_r963325138), so if we do make it normal by default, we may want to rename this...

Maybe we can even get rid of the flag, enable `--untracked-files=normal` by default and change to `--untracked-files=all` when `--granular` is used.

Would it be possible to make the outputs/dependencies absolute? i.e. ```python def test_repro(tmp_dir, make_tmp_dir, dvc): working_dir = make_tmp_dir("working_dir") working_dir.gen("foo", "foo") with dvc.lock: stage = PipelineStage( repo=dvc, name="stage", path=os.fspath(tmp_dir / "dvc.yaml"),...

> @skshetry What's the status of this one? Do you need someone else to take over? @dberenbaum, I have been prioritizing the bugfix for https://github.com/iterative/dvc/issues/8052 over this. The major issue...

I’ll remove index and push another version tomorrow. :)