Improve coverage of main features

Open jovan-stojanovic opened this issue 3 years ago • 1 comments

Here are some of the code coverage results:

------------------------------------------------------------------------
dirty_cat/_datetime_encoder.py             88%
dirty_cat/_gap_encoder.py                  88%
dirty_cat/_minhash_encoder.py              94%
dirty_cat/_similarity_encoder.py           90%
dirty_cat/_string_distances.py             91%
dirty_cat/_super_vectorizer.py             85%
dirty_cat/_target_encoder.py               78%
dirty_cat/_utils.py                        93%
dirty_cat/datasets/_fetching.py            97%
...
------------------------------------------------------------------------
TOTAL                                     89%

It may be good to work on improving those so that we have clear standards on what coverage is needed for new features.

Tests to Update

[x] skrub._datetime_encoder.py
[x] skrub._gap_encoder.py #434
[X] skrub/_minhash_encoder.py #379
[x] skrub/_similarity_encoder.py #444
[ ] skrub/_string_distances.py
[x] skrub/_table_vectorizer.py
[x] skrub/_target_encoder.py #375
[x] skrub/_utils.py
[ ] skrub/datasets/_fetching.py #429

Sep 22 '22 12:09 jovan-stojanovic

tablevectorizer & datetimeencoder are at 100% after #902 so we checked those in the list. @TheooJ will open a PR to remove the unused function in _utils.py

May 28 '24 15:05 jeromedockes