skrub icon indicating copy to clipboard operation
skrub copied to clipboard

Merge examples 2 and 3

Open jovan-stojanovic opened this issue 3 years ago • 1 comments

In the light of what we talked on improving user experience:

We can add example 3 as being the last part of example 2, rather than a separate example. Looking at those two, I think the message is the same:

  • we first explain what are dirty categories;
  • we show how the encoder deals with them and how can that be interpreted.

The similarity encoder is interpreted in example 2 and the gap encoder in example 3. We may merge them?

What to do you think?

jovan-stojanovic avatar Jul 22 '22 14:07 jovan-stojanovic

I agree ! You should perhaps wait for #287 to be merged before merging, as it modifies some big portions of these examples :)

LilianBoulard avatar Jul 27 '22 18:07 LilianBoulard