skrub icon indicating copy to clipboard operation
skrub copied to clipboard

Improve doc api reference

Open Vincent-Maladiere opened this issue 6 months ago • 2 comments

Fixes https://github.com/skrub-data/skrub/issues/1285

Vincent-Maladiere avatar Jun 20 '25 09:06 Vincent-Maladiere

Thanks a lot @Vincent-Maladiere, this is already looking so much better!

I think that most of the infrastructure is there, and now it's mostly a matter of deciding the order and the titles of the sections.

For example, I would like to reorder the objects in the skrub section of the section navigation index so that related objects were closer to each other (so that all the Encoders are next to each other, all the Joiners are next to each other and so on). Is that doable?

rcap107 avatar Jun 20 '25 11:06 rcap107

Discussed during the skrub meeting:

  • The current grouping of the objects is not very intuitive: objects should be grouped by functionality more than by namespace (all encoders together, all joiners together etc.). We might want to reflect the grouping that is used in the user guide.
  • For the moment, adding a search bar was more complex than expected, so it should be added at a later time

rcap107 avatar Jun 23 '25 11:06 rcap107

Thanks a lot for this PR.

I had a very quick look.

On the rendered page, I don't see the "section" titles appearing. For instance, the api_renference.py file suggests that the first part, the "pipeline" part, has a title "building a pipeline", but I don't see it: image

I think that it would really help if they appeared as dividers. I do note that it is not the case in the scikit-learn docs, so maybe it is not feasible.

GaelVaroquaux avatar Jun 24 '25 07:06 GaelVaroquaux

Thank you for your feedback. It's probably feasible, but I aimed to stick to the scikit-learn style. In this instance, if you click on "pipeline" on the left sidebar, you'll see that the title is indeed "Building a pipeline". So it all boils down to what we want. WDYT?

Vincent-Maladiere avatar Jun 24 '25 07:06 Vincent-Maladiere

It's probably feasible, but I aimed to stick to the scikit-learn style.

If we can improve on it, it is even better :)

In this instance, if you click on "pipeline" on the left sidebar, you'll see that the title is indeed "Building a pipeline".

Indeed, and that's pretty cool!

So it all boils down to what we want. WDYT?

That's true. I think that if we could have the section title separating a bit the big table it would be cool. If it's hard, then we move on and merge as is.

GaelVaroquaux avatar Jun 24 '25 13:06 GaelVaroquaux

I can give it a try!

Vincent-Maladiere avatar Jun 24 '25 14:06 Vincent-Maladiere

I can give it a try!

Thanks! And if you hit a snag, tell us, and we'll move on.

GaelVaroquaux avatar Jun 24 '25 14:06 GaelVaroquaux

@GaelVaroquaux is this last version better?

Vincent-Maladiere avatar Jun 24 '25 14:06 Vincent-Maladiere

This is amazing!!

One tiny remark: can we add somewhere in the dev guide how to add symbols to the API reference, to make it easier for people to find the relevant files. It's now a bit hard to find this

GaelVaroquaux avatar Jun 24 '25 15:06 GaelVaroquaux

can we add somewhere in the dev guide how to add symbols to the API reference

I added a small entry at the bottom of the development section

Vincent-Maladiere avatar Jun 24 '25 15:06 Vincent-Maladiere

Dostring failures :|

GaelVaroquaux avatar Jun 25 '25 08:06 GaelVaroquaux

darn! fixed :)

Vincent-Maladiere avatar Jun 25 '25 09:06 Vincent-Maladiere