skrub icon indicating copy to clipboard operation
skrub copied to clipboard
verified publisher icon skrub-data

Improve .expr.subsample docs

Open rcap107 opened this issue 6 months ago • 2 comments

Fixes #1446

Todo:

  • Add an example in the docstring
  • Add a cross-reference to the user guide
  • Expand a bit on this in the user guide

rcap107 avatar Jun 18 '25 14:06 rcap107

Talking with @Vincent-Maladiere, we thought of improving the error message by detecting when one of X and y is sampled, but the other isn't. This should be done in .skb.apply when an estimator that takes y is used.

It'll be a different PR though

rcap107 avatar Jun 19 '25 13:06 rcap107

ready for review, since we're not going to detect subsampling in this PR

rcap107 avatar Jun 23 '25 11:06 rcap107