TableVectorizer tests only check pandas dataframes

[rcap107]

Tests in test_table_vectorizer.py are all using example pandas only dataframes, rather than using df_module and testing pandas, pandas nullable types, and polars

We should update all the tests to address this

[rcap107]

from the skrub meeting: this is low priority and something to do when we have spare time

[shivanshutiwari35]

Hi @rcap107, since this issue was discussed to be a low priority. If it is alright, I can take it up. With this, I will also be able to get more familiar with the codebase.

Let me know if it's okay for me to proceed, or if there is any other instruction for me.

[rcap107]

Hi @shivanshutiwari35, thanks for offering your help! Yes, you're more than welcome to work on this issue.

You might want to work on this a few tests at a time (at least at the beginning), there are a lot of tests to go through and it might be easier to review and go over a few at a time rather than covering everything.

[shivanshutiwari35]

Thanks @rcap107 , I’ll start with a small batch of tests and open a PR for review. Based on the feedback, I’ll continue iterating in parts to keep it manageable.

[Vincent-Maladiere]

Hey @shivanshutiwari35, thank you for your interest! If you haven't already, I recommend that you read the contributing documentation to get familiar with our workflow.

[shivanshutiwari35]

Thanks, @rcap107, I’ll go through the contributing guide thoroughly and get started.

[rcap107]

Closed by #1618