skrub-data
Improve error message for non-dataframe input in the TableReport
Fixes https://github.com/skrub-data/skrub/issues/1408
Additionally, we could add this error message to all sbd functions. WDYT?
Additionally, we could add this error message to all sbd functions. WDYT?
i think that would be good, and I would suggest replacing the NotImplementedError with a TypeError -- for user point of view the issue is not a missing implementation, it's that they passed an unsupported type
I just realized there are more sbd functions spread around other files that should be updated, like in _datetime_encoder.py and _to_datetime.py
I think it's worth bringing them into the _common.py file for consistency and discoverability (currently, it's easy to forget them, as I just have)
As long as it does not lead to circular imports (which can be circumvented, but are a hint of bad code organization)
As long as it does not lead to circular imports (which can be circumvented, but are a hint of bad code organization)
I reverted my message after further reading, as I now understand that these functions make sense within their respective contexts
Technically, the coverage should be the same, because we're replacing an error with another one, but I can add a few tests to make codecov happier
Technically, the coverage should be the same, because we're replacing an error with another one, but I can add a few tests to make codecov happier
makes sense, but why is it complaining then :thinking: just coverage things?
I'm not sure, Codecov has been quite buggy in the past
Yes. It's not incredibly reliable.