skrub icon indicating copy to clipboard operation
skrub copied to clipboard

Remove distribution tiles when distributions aren't computed

Open Vincent-Maladiere opened this issue 8 months ago • 1 comments

Follow up on https://github.com/skrub-data/skrub/pull/1255#issuecomment-2766633436. In the TableReport, when the number of columns is greater than some threshold, we don't compute or display marginal distributions.

Removing these tiles entirely could improve the TableReport further since tiles stats are already presented in the 'stats' panel in a more compact format.

Image

Vincent-Maladiere avatar Mar 31 '25 16:03 Vincent-Maladiere

This was addressed (partially) in #1340 for the expressions. From what I remember, the hang up was deciding where to display the message about having too many columns. By keeping the tabs, we can show it in there, without the tabs, we need to figure out where to put it.

rcap107 avatar Jun 18 '25 13:06 rcap107

What I was suggesting was keeping the "Distributions" tab and removing the individual tiles. The blue message can stay.

Vincent-Maladiere avatar Jun 25 '25 13:06 Vincent-Maladiere

Like this:

Image

Vincent-Maladiere avatar Jun 25 '25 13:06 Vincent-Maladiere