skrub-data
FEA add link for HTML representation
This PR add the necessary class and function to add a link to the documentation when showing the HTML representation of an estimator. Unfortunately, there is a bug in scikit-learn that will be corrected in 1.6 and we need to vendor the fix and inherit from the mixin.
if the bug is in scikit-learn and this is not critical, could we just wait for it to be fix in scikit-learn without vendoring the htmlmixin class? also once it is fixed in scikit-learn would we still need to inherit from a private scikit-learn class?
could we just wait for it to be fix in scikit-learn without vendoring the htmlmixin class?
Yes but we need to bump the minimum version
also once it is fixed in scikit-learn would we still need to inherit from a private scikit-learn class?
Actually, we don't need to. We only need to set the class attributes. BaseEstimator is inheriting from this private mixin.
Yes but we need to bump the minimum version
This is somewhat unrelated to this PR, but we were thinking with @jeromedockes whether or not we should try to support as many Python and scikit-learn versions as possible, for many potential users are often stuck with an old Python version (e.g. APHP). We can talk about this idea somewhere else, though.
@Vincent-Maladiere I share the same feeling and this is the reason why to vendor for the moment as a fix.
@glemaitre could you do a
git commit --allow-empty -m '[doc build]' && git push
so we can see the new TableVectorizer display in the examples? thanks!
@glemaitre ok, I misread your first message. I'm +0 or +1 as long as we don't need to bump the minimal version.
