skrub icon indicating copy to clipboard operation
skrub copied to clipboard

include the skrub wheel in the built documentation

Open jeromedockes opened this issue 1 year ago • 2 comments

at the moment for jupyterlite we hardcode the link to a particular skrub version on pypi:

https://github.com/skrub-data/skrub/blob/b5962f705ee980e83ec07fc4eda0876b0ebdac6f/doc/conf.py#L386

however that version may not be the right one, and the right one may not be on pypi yet (eg when running the examples for the dev/ documentation, or when we make a release there is a chicken-egg problem:we would like to write the correct pypi link before releasing, but it doesn't exist before the release)

it would be better to build the wheel as a part of building the documentation and include it as a static asset. then in jupyterlite we would pip install the wheel that is in the same directory of the current site rather than a hardcoded one from pypi

jeromedockes avatar Aug 02 '24 10:08 jeromedockes

It would help indeed, and having a nightly as part of the dev docs would be amazing!

GaelVaroquaux avatar Aug 02 '24 10:08 GaelVaroquaux

https://github.com/jupyterlite/jupyterlite/issues/1023

jeromedockes avatar Aug 02 '24 11:08 jeromedockes

after discussing a bit it's probably not worth the effort; installing from pypi is good enough for scikit-learn so it's probably good enough for skrub as well :)

jeromedockes avatar Oct 23 '24 12:10 jeromedockes