elasticsearch-analysis-greeklish icon indicating copy to clipboard operation
elasticsearch-analysis-greeklish copied to clipboard

Mapped c to greek letter ψ in the greeklish generator

Open galanis-a opened this issue 5 years ago • 5 comments

galanis-a avatar Oct 22 '19 22:10 galanis-a

@galanis-a hey, thanks for this PR. Could you please give the rationale behind the change and its intended effect? I am not sure c is a valid greeklish substitute for ψ. e.g ψωμι would be psomi or pswmi but not cwmi or comi.

greenonion avatar Oct 23 '19 07:10 greenonion

Hello @greenonion,

i added this because when you try typing somehting like vichy with greek letter is ωιψηυ, The c letter is ψ in this case. So i think c can map to ψ as well as ps.

galanis-a avatar Oct 23 '19 07:10 galanis-a

I imagined that would be the case. Unfortunately, this is out of scope for this plugin, as it only tries to handle Greek words written using Latin characters, not the other way round. Our wiki has an example.

We could possibly add a setting to enable/disable this functionality though, but currently this is low priority for us. If you're interested we could guide you through it.

greenonion avatar Oct 23 '19 07:10 greenonion

Yeah sure would love your help on making the setting.

galanis-a avatar Oct 23 '19 07:10 galanis-a

Hello @greenonion,

I added the setting for the special mapping to map c to ψ. Also update the test files and testing on my local elasticsearch server. But the only name i came up is "special mapping", don't think its pretty good. If you could help on this, and come up with something that would match better.

Best.

galanis-a avatar Oct 24 '19 09:10 galanis-a