Stefan Krawczyk
Stefan Krawczyk
> Either one could be OK I think. > > That said, I want to try something like the following, in the driver: > > ``` > sys.modules['pandas'] = modin.pandas...
> And if `modin` was detected as being installed, it would be returned, otherwise vanilla pandas would be. Just putting it in here, that we could use https://docs.python.org/3/library/importlib.html#checking-if-a-module-can-be-imported or something...
Thanks @devin-petersohn comments inline: > When would you change `sys.modules`? > * If it happens on import, and the user doesn't end up using Hamilton after import, they may still...
@devin-petersohn sounds good. Do you happen by chance to have that hacky incantation?
@devin-petersohn okay so we can't play with sys modules, because modin still requires access to pandas. So you'd have to provide a means to do it. Created https://github.com/modin-project/modin/issues/4488 to track....
will redo this once tagging & data quality have been merged.
#184 implemented this. closing
Thanks @wangkev ! I believe I punted on this on purpose; I usually wait for a use case to implement a feature. Question -- why union support? You don't want...
@wangkev want to give this branch a spin too? https://github.com/stitchfix/hamilton/pull/173 It should fix this issue.
@wangkev I think going from subset to superset is fine. But going from superset to subset is asking for errors. E.g. I think this should be fine (I just pushed...