skpratt issues

Results 11 issues of


                                            skpratt

Refactor sidecar_service method to separate port assignment

### Description This separates the port assignment logic out into a helper. That way it can later be moved to a different step in the registration process. ### Testing &...

pr/no-changelog

Move sidecar port assignment logic to locked stage of add flow

### Description This relocates automatic sidecar port assignment logic to a locked method immediately before registration, thereby preventing collisions when handling simultaneous requests. ### Testing & Reproduction steps Manual verification:...

Remove legacy acl policies

### Description This change removes all uses of legacy ACL policies from consul. ### Testing & Reproduction steps Tested locally and on EKS. Bootstrapped ACLs for 3 server cluster with...

theme/api

theme/acls

theme/cli

theme/ui

theme/envoy/xds

Update token language to distinguish Accessor and Secret ID usage

### Description Clarify in CLI and code when we are using a token's AccessorID vs SecretID. ### Testing & Reproduction steps Tested locally - bootstrapped ACLs for 3 server cluster...

theme/api

theme/cli

Errors/acl not found improvements

### Description These errors provide additional helpful information in the case where the ACL system has not been bootstrapped and when a token does not exist. ### Testing & Reproduction...

theme/api

theme/cli