skorch icon indicating copy to clipboard operation
skorch copied to clipboard

Update MNIST.ipynb

Open chrishwiggins opened this issue 2 years ago • 3 comments

threw an error as written; should work w/o the added arguments

error:

TypeError                                 Traceback (most recent call last)
<ipython-input-3-19c8d440ea79> in <module>
----> 1 mnist = fetch_openml('mnist_784', as_frame=False, cache=False)

TypeError: fetch_openml() got an unexpected keyword argument 'as_frame'```

chrishwiggins avatar Sep 02 '22 11:09 chrishwiggins

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hey, thanks for the PR :) What version of sklearn do you use to test this with? As far as I can see version 0.22 has this parameter (and is the minimum version that skorch requires).

ottonemo avatar Sep 02 '22 11:09 ottonemo

@chrishwiggins I'm closing this for now, given the comment by @ottonemo. If there is something we missed, please open an issue.

BenjaminBossan avatar Sep 16 '22 11:09 BenjaminBossan