skops icon indicating copy to clipboard operation
skops copied to clipboard

Have example scripts for every task

Open merveenoyan opened this issue 2 years ago • 6 comments

We should have example scripts for every task we will support, as we develop model card features/inference specific features for the task and showcase them. We need scripts for below for the planned tasks:

  • [ ] tabular-regression
  • [ ] text-classification
  • [ ] text-regression

The tabular-classification one already exists for the features we have now, but maybe we could have a more end to end one that has both hub_utils and card in one place for the task.

merveenoyan avatar Aug 25 '22 17:08 merveenoyan

we first need to handle #102 for the text stuff, but yes.

adrinjalali avatar Aug 25 '22 17:08 adrinjalali

I'm just wondering: are classification vs regression different enough that we need a separate example? For text input, I agree.

BenjaminBossan avatar Aug 26 '22 08:08 BenjaminBossan

@BenjaminBossan I think the visualizations and metrics are different and at one point we might have methods specified to tasks so it's good imo (nice to have after we get everything done).

merveenoyan avatar Aug 26 '22 10:08 merveenoyan

Hi! I've added an example of tabular regression in #254. Let me know if I did anything wrong!

lazarust avatar Dec 15 '22 00:12 lazarust

@merveenoyan I think the text-classification task is already done in /examples/plot_text_classification.py unless I misunderstand the task? It looks like the text-classification example is still using pickle instead of skops.io so I can update that if needed.

lazarust avatar Dec 19 '22 01:12 lazarust

@lazarust thanks a lot for the contribution, and yes, it was already done! I was wondering if for now we should keep the pickle as we don't support skops format for inference API. I will work on it in upcoming weeks after I catch up and wrap up other stuff. For now, I say we keep it.

merveenoyan avatar Jan 03 '23 14:01 merveenoyan