express-http-context icon indicating copy to clipboard operation
express-http-context copied to clipboard

Published 20 hours ago • verified publisher icon skonves

Moving @types dependencies to devDependencies

Open barakshechter opened this issue 5 years ago • 2 comments

Moving the type dependencies to devDependencies since the compiled index.js has no direct need for them. The only hard dependency this library needs is cls-hooked.

barakshechter avatar Dec 03 '19 20:12 barakshechter

Coverage Status

Coverage remained the same at 100.0% when pulling 74da83724353506e1baf7ccff670c8105097a1d5 on barakshechter:move-type-deps-to-dev-only into f6b63dc89618b9890066dd5387466701a2e293dc on skonves:master.

coveralls avatar Dec 03 '19 20:12 coveralls

Hi @skonves ,

I was depending on your library when I noticed it had a hard dependency on express types, which theoretically only apply when developing in typescript.

barakshechter avatar Dec 03 '19 20:12 barakshechter