Sergey Komisarchik

Results 21 comments of Sergey Komisarchik

@kentonbmax can you provide a minimal example that reproduce the problem?

Yes, the same issue #158 @niemyjski , it means the binary version of `Microsoft.Extensions.Logging` is different ( `Microsoft.Extensions.Logging (2.0.0)` -> `Microsoft.Extensions.Logging.Abstractions (2.0.0)` `` -> `Microsoft.Extensions.Logging.Abstractions (3.1.3)` If you not add...

@krafs , @nblumhardt the reason why `IConfigurationSection` parameters were obsoleted is to support `IConfiguration` sinks arguments, such as [Serilog.Sinks.MSSqlServer](https://github.com/serilog/serilog-sinks-mssqlserver/blob/dev/src/Serilog.Sinks.MSSqlServer/Configuration/Extensions/Microsoft.Extensions.Configuration/LoggerConfigurationMSSqlServerExtensions.cs#L112)'s (in order to get root `ConnectionStrings` section etc). See #148 and...

> I think where this gets confusing is that IConfigurationSection implements IConfiguration anyway, so the API we have here doesn't really enforce the kind of usage that the MSSQL sink...

👍 I'll come up with something based on your suggestions

I'm on simplifying syntax and making it more streamlined 👍 I've played around with proposed syntax and made some list of pros and cons. ```json "WriteTo": { "File": { "path":...

I'm really like it. If not taking into account current syntax third one has no inconsistencies of the first version when introducing new sinks of the same kind, and it...

The boolean semantics is interesting (and supported of course). And actually may be useful for suppressing output, for example via environment variables: ```csharp set Serilog:WriteTo:LiterateConsole=false ; // or 0 ```...

Would be great to add support for this . Without upstream support we could solve it with adding additional parameter or new overloads to `ReadFrom.Configuration` with switch collector type: ```csharp...

@tsimbalar some generic type was in my mind too. 👍 `out` modifier seems good addition. No need to import additional namespace for the type in case of inline initialization .