will icon indicating copy to clipboard operation
will copied to clipboard

#379 Set will_is_mentioned even if message was direct

Open dawn-minion opened this issue 6 years ago • 4 comments

PR makes it so will_is_mentioned is set, even if message was determined to be direct (Began with the Chatbots handle). Change affects only HipChat and Slack, as RocketChat already seems to have this correct behaviour since it checks the mention list.

Simply moved the will_is_mentioned to before where the name is stripped out.

Fixes #379

dawn-minion avatar Jul 30 '18 13:07 dawn-minion

/cc @unicolet

dawn-minion avatar Jul 30 '18 13:07 dawn-minion

let me understand the behavior a little more, if you say

Lets go ahead and deploy (at)Chatbot deploy production

in your WillPlugin, the respond_to is set to

^Lets go ahead and deploy (at)Chatbot deploy production$

?

wontonst avatar Jan 28 '19 20:01 wontonst

@wontonst The respond_to in our case was only set to the @chatbot deploy production message, which we wanted to be able to exist anywhere in the message. The main thing I wanted was for a user to give the bot a command in the middle of their message like the above example.

dawn-minion avatar Jan 29 '19 08:01 dawn-minion

I see. Let me rephrase my question. With the ability to give the bot a command in the middle of the message, what does the will respond_to look like when you match with anchors? In the example, would will respond to

^Lets go ahead and deploy (at)Chatbot deploy production$

or

^deploy production$

wontonst avatar Jan 29 '19 16:01 wontonst