django-longer-username icon indicating copy to clipboard operation
django-longer-username copied to clipboard

Test wasn't relevant enough, this fix makes it much faster as well.

Open AdrienLemaire opened this issue 12 years ago • 6 comments

Please notice that the Pypi version of django-longerusername is broken. Consider updating it, thanks

AdrienLemaire avatar Mar 23 '12 03:03 AdrienLemaire

Pull requests that improve tests make me super-happy.

Could you actually add this as a second test instead of replacing the first? The original one is just testing that the monkeypatch didn't completely bork User. Yours does the relevant work of checking the length. Both are useful.

skoczen avatar Mar 23 '12 03:03 skoczen

Pypi: please use http://pypi.python.org/pypi/longerusername/

Someone else added django-longerusername, and I haven't been able to get in touch with him.

Edit: I was able to get in touch with the guy who added django-longerusername, and it's been pulled. Hooray for less confusion!

skoczen avatar Mar 23 '12 04:03 skoczen

I am said idiot. My apologies. I've removed the confusing pypi package.

Thanks so much for putting together a great and useful app.

matthanger avatar Mar 23 '12 04:03 matthanger

Matt -

Sorry for calling you an idiot. Edited this as soon as I heard from you. That was the "I saw this a few months ago and never took the time to google you down" frustration talking.

Thanks for your enthusiasm, and quick response in getting it cleared up!

skoczen avatar Mar 23 '12 04:03 skoczen

No worries. Thanks for calling me out/keeping me honest.

matthanger avatar Mar 23 '12 04:03 matthanger

Done. You'll probably want to add a run_tests.py script to make it easy to verify the tests for this app. Also, your setup.py needs more informations, eg the python classifiers for better PyPI referencement.

Cheers.

AdrienLemaire avatar Mar 23 '12 05:03 AdrienLemaire