Siu Kwan Lam comments

Results 276 comments of


                                            Siu Kwan Lam

`numpy.median` behaves differently with it using `njit`

Issue reproduces

`numpy.percentile` behaves differently with it using `njit`

Issue confirmed. There's missing INF handling when percentile is not 0 or 100. https://github.com/numba/numba/blob/main/numba/np/old_arraymath.py#L1647-L1652 There were discussion in the implementing PR about INF handling. https://github.com/numba/numba/pull/2953#issuecomment-392063168 The following diff seems to...

Add basic infra required to move Numba to NewPassManager

BFID: `llvmlite_290`

Add basic infra required to move Numba to NewPassManager

build passed

restype missing for all llvm APIs that return void

For short term fixing the issue, the best practice is to set restype to None for void returning function. For long term avoiding the issue, it was suggested in today's...

Caching causes error in structref overloading

I have debugged this problem and the root problem is an odd behavior with `cloudpickle` and the `__main__` module such that the `ExampleType` on the first run is treated as...

Return `Tuple` type containing `Record` type has an error

I started a patch (that I don't have time to finish in the near-term) to add refcount tracking to `Record` type. Diff at https://github.com/numba/numba/compare/main...sklam:enh/refct_record?expand=1 The branch is minimally tested with...

ValueError: not enough values to unpack (expected 1, got 0)

One suggestion in the dev meeting is to change the exception raised when it can't find the jump target so looplifting will fallback.

`test_target_extension.TestTargetHierarchySelection.test_overload_allocation` fails when run in isolation

The problem is weird because no amount of manual calling of `refresh()` is fixing the problem. But calling a empty `dpjit` function once does. I'm wonder if the problems are...

Platform-dependent Compilation Failure

@hameerabbasi For security reasons, we can't open zip archive. Can you resend the content as plain text or via https://gist.github.com/? Also, looking from the original issue, was there a segfault?