photofilters icon indicating copy to clipboard operation
photofilters copied to clipboard

Optimisations

Open jimmyff opened this issue 4 years ago • 6 comments

Hey, this is a great package however it regularly crashes my development enviroment and also sometimes crashed on my pixel 3 device. I think it's because it's applying each filter to the full sized image every time. I notice in your example you resize the image to 600 however i need a higher quality version for my app.

Could it generate thumbnails using a much smaller version of the source image and then when the user selects a filter apply that one on the full sized image? I think it would make the whole thing much more stable and feel more responsive.

jimmyff avatar Oct 22 '19 16:10 jimmyff

@jimmyff Thanks for the suggestion,

I am planning to implement the same in the very next release. If you already worked out something, please send a PR.

Thanks

skkallayath avatar Oct 23 '19 17:10 skkallayath

hello...any update on this? thanks

Nemesis19 avatar Feb 21 '20 11:02 Nemesis19

@Nemesis19 Did you find anything on this?

vermavashish avatar Jul 08 '20 14:07 vermavashish

I Found the issue with the code, its due to spawning multiple isolate using the compute function but not all the isolates get killed when you are done using the filter

Mangielijah avatar Jul 10 '20 07:07 Mangielijah

@Mangielijah Thanks for finding out the issue. From the comments of the other issue, I assume you fixed it by creating a worker for the compute operation and kill it later. It will be very helpful if you can create a pull request with the changes.

skkallayath avatar Jul 25 '20 17:07 skkallayath

Eagerly waiting for this to be fixed!!!

Shiba-Kar avatar Dec 01 '21 14:12 Shiba-Kar