John Molakvoæ

Results 952 comments of John Molakvoæ

> What’s missing is merging `.github/workflows/psalm-github.yml` and `.github/workflows/static-code-analysis.yml` together to avoid running psalm twice and make sure our baseline is correctly used. Yes, it was on purpose, I assumed we...

I fixed it on master (26) last week. https://github.com/nextcloud/server/pull/36999 At least part of what seems to be described in the first post screenshots :thinking:

> @skjnldsv this feature is scheduled for 27 as long as it's merged before Tuesday morning :wink:

``` --- Failed scenarios: /drone/src/build/integration/features/contacts-menu.feature:74 /drone/src/build/integration/features/contacts-menu.feature:109 /drone/src/build/integration/features/contacts-menu.feature:164 /drone/src/build/integration/features/contacts-menu.feature:178 ``` Seems related though

> @skjnldsv are you sure? The contacts menu integration tests fail on so many PRs recently seems like you're right indeed :)

What's the status here @joshtrichards :)

> If you pick a custom background, the automatic color extraction by @skjnldsv will mostly take care of it (and set e.g. white as background color, so the icons would...

> However if the majority of the image is not white, it can still be fixed by changing the color. No additional setting needed I'd say. The invert of the...

> > What about adding a switch that allows to invert the header icons? (I fear Ii don't see any other good solution to automate this) > > What about...