Simon Kern comments

Results 155 comments of


Simon Kern

Select first/last-used result on enter

Awesome! Is there a possibility to get the other feature on the roadmap? 😇 It was really useful in Everything that after selecting a certain file from a query, next...

fix writing of decimal sample frequency

I changed using `@master` to `@v3` and `@v4` in GitHub actions as suggested generally in https://github.com/actions/upload-artifact/issues/41 (not specifically for Python setup in GitHub actions, but is probably generally better to...

fix writing of decimal sample frequency

Went once through all the changes, added some more comments. I think all changes are okay and it's long overdue to merge this PR Thanks for @gcathelain for reviewing! I'll...

Re-writing EDF file changes signal data and signal header values

This is due to rounding errors that get introduced by converting forth and back from digital to analog signal space. EDF saves files in digital space (i.e. amplifier integers), and...

Re-writing EDF file changes signal data and signal header values

That's strange - do you have a sample file and code for me to check? (if you can't share the file publicly, you can upload it here: https://cloud.skjerns.de/index.php/s/Zc23TPbMrMBkK3, password='edfupload', files...

Re-writing EDF file changes signal data and signal header values

I think that's due to rounding errors in `edflib.c` https://github.com/holgern/pyedflib/blob/3bbcdc03396cf88d3bc73b276e65acf55fac520a/pyedflib/_extensions/c/edflib.c#L5725 ``` printf("My pre value is: %f\n", hdr->edfparam[i].phys_max); p = edflib_snprint_number_nonlocalized(str, hdr->edfparam[i].phys_max, 128); printf("My post value is: %s\n", str); # My...