librain icon indicating copy to clipboard operation
librain copied to clipboard

librain_draw_finish() vs. librain_draw_finish_all()

Open retostockli opened this issue 4 years ago • 1 comments

librain declares these two functions: librain_draw_finish_all() librain_draw_prepare_all()

But the plugin uses: librain_draw_finish_all() librain_draw_prepare_all()

This yields to a build error for the plugin: ../plugin.c: In function ‘draw_rain_effects’: ../plugin.c:559:2: error: implicit declaration of function ‘librain_draw_prepare’; did you mean ‘librain_draw_prepare_eye’? [-Werror=implicit-function-declaration] librain_draw_prepare(B_TRUE); ^~~~~~~~~~~~~~~~~~~~ librain_draw_prepare_eye ../plugin.c:565:2: error: implicit declaration of function ‘librain_draw_finish’; did you mean ‘librain_draw_finish_all’? [-Werror=implicit-function-declaration] librain_draw_finish(); ^~~~~~~~~~~~~~~~~~~ librain_draw_finish_all cc1: all warnings being treated as errors

Question: can I exchange the plugin functions with the _all() functions of the librain code? Reto

retostockli avatar Feb 26 '20 19:02 retostockli

I changed these too, since if I don't (remove -Werror=...) I get errors starting the plugin in x-plane. When I changed them, I got to a librain plugin that actually started in x-plane-11.50rc3 and with https://forums.x-plane.org/index.php?/files/file/50106-default-c172-librain-integration/ it even logs things (when the datarefs are set to verbose) In vulkan I see 0-1 fps loss (rounded down) in opengl 2-4. But....

I don't see anything on the screen/glass. Like there is no rain.

kukel avatar Sep 03 '20 18:09 kukel