simple-php-router icon indicating copy to clipboard operation
simple-php-router copied to clipboard

InputItem::offset returntype

Open Reviewmaximizer2022 opened this issue 3 years ago • 5 comments

Deprecated: Return type of Pecee\Http\Input\InputItem::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Fix: Add the #[\ReturnTypeWillChange] attribute to the offsetGet method or add return type to be bool|null

Reviewmaximizer2022 avatar Nov 10 '22 13:11 Reviewmaximizer2022

Hey,

this project is currently not supported for php 8. My fork has a php 8.1 branch.

Warning: There are a lot of undocumented breaking changes to the InputHandler. I hope to document it in the comming weeks.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/developermarius/simple-php-router"
        },
        {
            "type": "composer",
            "url": "https://packagist.org"
        }
],
"require": {
  "pecee/simple-router": "dev-v5-development-php8"
}

~ Marius

DeveloperMarius avatar Nov 10 '22 14:11 DeveloperMarius

Is this a repo that's currently open to new contributors? I would love to make a contribution and get it out. For basic users like myself, this is the only blocker to using php8, but it is a major one. @skipperbent @DeveloperMarius . I'm happy to make a PR or even take on a larger role in the repo. This is a great repo that I would hate to see die.

Mcgurk-Adam avatar Jan 26 '23 22:01 Mcgurk-Adam

Hey, my repo is always open for contribution and is php 8.1 compatible. Feel free to create a PR.

~ Marius

DeveloperMarius avatar Jan 26 '23 22:01 DeveloperMarius

Is this a repo that's currently open to new contributors? I would love to make a contribution and get it out. For basic users like myself, this is the only blocker to using php8, but it is a major one. @skipperbent @DeveloperMarius . I'm happy to make a PR or even take on a larger role in the repo. This is a great repo that I would hate to see die.

@Mcgurk-Adam , @DeveloperMarius If you can point me in the direction on how to create a maintainer i would be more than happy to give you guys the role. Do I have to create a team first?

skipperbent avatar Feb 09 '23 02:02 skipperbent

Hey @skipperbent ,

Try collaborators in the settings of the repo. But I am not quite sure myself.

~ Marius

DeveloperMarius avatar Feb 09 '23 07:02 DeveloperMarius