simple-php-router icon indicating copy to clipboard operation
simple-php-router copied to clipboard

print return callback by ExceptionHandler

Open DeveloperMarius opened this issue 3 years ago • 0 comments

Hello @skipperbent,

thanks to the Issue #606 by @riku22, after some deep debugging, I was able to discover two cases, where the rewriteCallback return value is ignored and therefor not printed as the output.

The first case was like I sayed discovered by #606: When you rewrite the callback in an errorHandler, the return value is not printed as the output. https://github.com/skipperbent/simple-php-router/blob/13fbbc88c23d00807b2883b6e2b65180f47b5871/src/Pecee/SimpleRouter/Router.php#L434-L437

The second case is very similar. This takes place when the wrong request method is used but the route exists. In this case there is the same error occurs. https://github.com/skipperbent/simple-php-router/blob/13fbbc88c23d00807b2883b6e2b65180f47b5871/src/Pecee/SimpleRouter/Router.php#L442-L445

@skipperbent please merge.

~ Marius

DeveloperMarius avatar Feb 02 '22 10:02 DeveloperMarius