simple-php-router icon indicating copy to clipboard operation
simple-php-router copied to clipboard

Dynamic domain, fixed Subdomain

Open swarnat opened this issue 4 years ago • 1 comments

We need the feature to use a fixed subdomain and get the domain as dynamic parameter. Implementation was easy: We added the dot as separator before parameters.

With another modification, We are not fully sure, if there are side effects. All tests passes. Now we only add a slash add beginning of $url, when the route start with a parameter.

I don't think there are side effects, because the prefix slash is only need to match on routes, which start with a parameter. Otherwise there are existing separators in url. But it is not fully clear, why a separator is needed, because regular expressions also match without one.

We would adjust the solution, depending on feedback.

To check all options, we need a "debugOutputNoReset" function in TestRouter, we also commit.

swarnat avatar Oct 03 '21 23:10 swarnat

Hello,

nice implementation, but can you provide an example where you need a dynamic second level domain?

~ Marius

DeveloperMarius avatar Feb 01 '22 22:02 DeveloperMarius