simple-php-router icon indicating copy to clipboard operation
simple-php-router copied to clipboard

PHPdoc fix (add where was clear), some code style fixes, removed some comments from prod

Open tahrz opened this issue 7 years ago • 4 comments

… comments from prod

tahrz avatar Dec 05 '18 09:12 tahrz

Nice work. One thing though, if you don't return static, the code completion won't recognize the new class if you extend it from a parent class; then only methods and properties from the base class will be available.

skipperbent avatar Jan 27 '19 12:01 skipperbent

Nice work. One thing though, if you don't return static, the code completion won't recognize the new class if you extend it from a parent class; then only methods and properties from the base class will be available.

Hi! Thanks, can you comment line from changed files, to show what exactly mean?

tahrz avatar Jan 27 '19 15:01 tahrz

Sorry about that, ive added the explanation on a line so it hopefully makes more sense.

But nevertheless it's great work :)

skipperbent avatar Jan 27 '19 16:01 skipperbent

Sorry about that, ive added the explanation on a line so it hopefully makes more sense.

But nevertheless it's great work :)

:) sorry, I don't see your explanation on any line :(

tahrz avatar Jan 28 '19 07:01 tahrz