Hartley McGuire

Results 77 comments of Hartley McGuire

Drafted because rubygems/rubygems#6985 hasn't quite been released yet

Yes I was wrapping it up yesterday, let me push it up Edit: unless you mean can the Dockerfile also read the .ruby-version for the image version, in which case...

> Also, do we need the version split if Ruby 3.1+ is now required? We do definitely need the split on using `file:` since it was added in Bundler 2.4.20...

@dhh this should be ready to go 👍

> I am a little uncertain about us adding a feature to the RubyTracker that the ERBTracker does not have I was afraid you would say this 🙈 haha I'll...

@jhawthorn, I added the feature to the ERBTracker and updated the test to run against all three trackers. Anything else you think we should add?

> But it looks like that `inverse_of` config is not being automatically derived, even though Rails should be capable of doing so. I think it may be an unfortunate effect...

> Would there be any plans to back-port this functionality to Rails 6.1 after it's merged and stable? At this point 6.1 only receives security fixes, and bug fixes are...

> First of all it looks like the `_default` option is not publicly documented which usually implies it is reserved for Rails itself and not intended for application's use. Also...

> ```diff > @@ -167,10 +167,10 @@ > > # might have been removed/replaced during init_plugins: > summary = reporter.reporters.grep(SummaryReporter).first > - return empty_run! options if summary && summary.count ==...