Hartley McGuire

Results 77 comments of Hartley McGuire

> > > Thanks for looking into this @SkipKayhil, I think it'd be good to instrument this in a full dry-run rather than in isolation, as the parsing step only...

> are you still interested in driving it to completion? Would definitely still love to see this merged! I just gave it a rebase and will update if anything fails...

Closing as completed by #49290 and #50468

https://github.com/rails/rails/issues/40109#issuecomment-680799482 Reproduction still fails on 7.0.4.2 and main

Right, my understanding is either casing is valid in HTTP/1.1 spec, and the Rack spec doesn't actually say anything about how the server should respond. However, I believe the current...

> If we go lowercase, these should change too (unrelated to this issue which is more about puma -> client header casing) Those should definitely be downcased for Rack 3...

hey @tancnle, anything I can do to help get this merged?

^ignore my mention, I have too many tabs open 😅

I tried to wrap my head around the `statement not reached` warnings but haven't cracked it. An example is this: ```ruby # lib/mail/parsers/content_location_parser.rb when 17 # line 24 "lib/mail/parsers/rfc5322_lexical_tokens.rl" begin...

> It might be better to set things up so warnings are not generated for these files. Since the `parser` gem uses the same trick to fix the `testEof` warning,...