Hartley McGuire

Results 77 comments of Hartley McGuire

Hey, @noriyotcp, thanks for the PR! I'm a little bit confused about the desire for this change. Is there a reason you wouldn't be able to use `= f.submit 'Submit',...

> Looks like this is intentional Beat me to it by seconds 😆 For some more context: added in af1680f to fix #26033 @matteo-rossi-wise what is the high level expected...

Very related: #45241, it may be worth trying to work together on this one

> we can configure Rails 8 to use the `sqlcommenter` format by default If the goal is to make it the default, should we not create the `new_framework_default` now?

> It doesn't seem like a blocker for the attached PR Agree, we can probably wait until the PR is merged before handling this. Assuming we want this in the...

Hey @onlynone, thanks for opening an issue. I've opened a PR to fix `--skip-listen` for Rails 6.1, however I think its unlikely that it ever sees a release because 6.1...

> But `app:update` only supports some of them. And it only infers the ones it does support by checking which gems have been loaded: I believe all of the options...

I appreciate the desire to make improvements, and PRs are always welcome! However, I'm going to close this as we reserve the issue tracker for bugs only and the original...