Hartley McGuire

Results 108 comments of Hartley McGuire

Allow upgrade to rack 3.0

> * [Blade](https://github.com/javan/blade) has a dependency on [Thin](https://github.com/macournoyer/thin) - which is locked at https://github.com/macournoyer/thin/blob/10607a2663fc282d67f98a930f954dc407fd056d/thin.gemspec#L25. I think that rails-ujs is no longer used by default so maybe we should remove it...

Fix _read_attribute so it uses aliased attribute name as well

This looks like it would be losing the speed gained in 7834363, definitely want a benchmark to see for sure. Edit: maybe removing `name = attr_name.to_s` would be sufficient?

Adds schema parameter into enable_extension

> I'm having issues on 2.7 on ActiveSupport's `OptimizedMemCacheStoreTest#test_big5_hkscs_encoded_values` I believe that's just a flaky MemCache failure, I wouldn't worry about it

[AR] Fix result with anonymous PG columns of different type from json

Test failures look real

Rails & can't pin JS files from Unpkg

This sounds like an issue with the jspm api. I'll leave this open for a bit but an issue should probably be raised with them

Fix `ActiveRecord::QueryMethods#in_order_of` to work with nils

Some previous discussion at #44814

Extra stuff after charset in Content-Type disappears

I'll reopen since stale PRs don't get closed now

System test with importmap

Do you have a repo/reproduction where you can show this happening? It's very hard to figure out what is going wrong without one

HostAuthorization: confusing error message when using multiple hostnames

Hey @Eusebius1920, sorry you've gone so long with no response. Would you still be interested in opening a PR to fix this? I agree that the error message could be...

Action mailbox migration does not respect the active record's primary_key_type

> Confirming this is still a problem on Rails 7.0.4. Thanks for bumping this, I've opened a PR.