Tolga Ceylan

Results 12 comments of Tolga Ceylan

Fixes https://github.com/golang/go/issues/35025

oh, this looks legit. While LB is finishing off reading from Runner (the goroutine above), the runner_invoke.go code might be already writing headers. I noticed that most of these headers...

I don't think the issue is specific to detached mode. In both modes, a shallow copy of header is being made and while the headers are being set, the logger...

resp writer that is safe is probably a good option. Otherwise, we'd need to: 1) make sure in receiveFromRunner header.Set() (case *pb.RunnerMsg_ResultStart:) is not executed after TryExec() returns 2) logger...

We can perhaps think of other options. IMHO, concurrent/safe resp writer itself is a red flag. runner_client could perhaps create headers/buffer and then move these and relinquish ownership when done....

w/o copy is going to require iface changes to bunch of places since this is abstracted by resp writer iface. :-( For short term, I think we can surgically fixup...

The option to disable it is documented here: https://github.com/fnproject/fn/blob/master/docs/operating/options.md

We have various functions in cookie.go to configure the container/host config. That would be a place to possibly add this. (eg. add new function such as **cookie.configureDevices()**). I'm guessing this...

I meant to say, an implementer can write their own driver for this purpose. I'm not sure if we want to add device mapping and/or privileged mode into Fn.

Distribution buckets should be configurable. eg: https://github.com/fnproject/fn/blob/master/cmd/fnserver/main.go#L30