test-with-actions icon indicating copy to clipboard operation
test-with-actions copied to clipboard

[Feature] Improve clarity on step 2

Open Deselikem opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe. hard to understand what is meant in the image below

image

Deselikem avatar Jun 24 '22 19:06 Deselikem

yes what does that mean? in the instructions it says to update the code in the ci branch. what code? what are you supposed to update? you need to look for something like underscore look for it where? look for that text literally? The only place I was able to find that text was in the readme.md file that I was reading it in.

ProDataMan avatar Jul 13 '22 18:07 ProDataMan

Check the error in the ci.yml build and you will find a helpful warning message.

sinsukehlab avatar Aug 04 '22 11:08 sinsukehlab

The instruction should have explained what the installed packages do https://unifiedjs.com/explore/package/remark-lint-emphasis-marker/

This package is a unified (remark) plugin, specifically a remark-lint rule. Lint rules check markdown code style. You can use this package to check that emphasis markers are consistent.

This would make it way less confusing.

thongonary avatar Aug 18 '22 09:08 thongonary

Step 0 contains a link to the remark-lint GitHub repository, but is commented out by 0-start.yml.

sinsukehlab avatar Aug 18 '22 10:08 sinsukehlab

look at the read me, line 115. The libraries cause rules to be implemented based on emphasis...I was stuck on this for about 1:30 hour

MathElderGod avatar Oct 27 '22 08:10 MathElderGod

Still trying to figure out the solution on how to complete this activity Fix the test

Anyone with more direct guidance? thanks,

ted-repo avatar Nov 21 '22 10:11 ted-repo

Go to the Actions tab and check the error. Follow the warning message.

found 0 vulnerabilities
README.md
  115:1-115:63  warning  Emphasis should use `_` as a marker  emphasis-marker  remark-lint

⚠ 1 warning
Error: Process completed with exit code 1.

sinsukehlab avatar Nov 21 '22 11:11 sinsukehlab

For anyone stuck at this step: Go to line 115 in readme and change both "*" into "_".

AndylLow avatar Dec 04 '22 15:12 AndylLow

still stuck. Action workflow screenshot shown just before line 115 doesn't look like what I am seeing on my workflow (ie, I don't see "Review required", the first big :x:)

k-byun avatar Dec 21 '22 06:12 k-byun

If you're not seeing the ❌ Some checks didn't pass message, chances are you left extra lines in the workflow file.

Go back to Step 1, Task 6. Open ci.yml and delete everything from line 28 to EOF. Now the last non-blank line in your file should read - uses: actions/checkout@v3. Continue with Task 7 and add the markdown lint step.

If that doesn't help, try deleting the repo and starting over.

leonfeng avatar Dec 22 '22 04:12 leonfeng

Thank you @leonfeng and @AndylLow for your solutions. This has finally worked for me 🙏

ndagisusan avatar Jan 07 '23 08:01 ndagisusan