publish-packages
publish-packages copied to clipboard
Add an extra step to detail Docker environment clean up
Summary
Add steps to detail cleaning up the Docker environment (stop container, delete image).
These courses are great and offer a low barrier of entry for beginners. Since beginners can work through this course it is a good idea to also include how to stop the Docker container and also remove the image when we're done with it.
Changes
- Adds a Step 6 markdown file
- Modifies the third Actions workflow file to include Step 6 markdown content
- Modifies the Step 1 markdown file to emphasize the
cdrepo with inline code tags (as seen to the left)- (This matches the style convention in later Step markdown files.)
Closes: #47
Task list
- [x] For workflow changes, I have verified the Actions workflows function as expected.
- [x] For content changes, I have reviewed the style guide.
I performed testing via this temporary repo: https://github.com/mjbear/test_skills-publish-packages (Once this is evaluated and hopefully merged, I plan on deleting that "test" repo.) :grinning:
Is there an simple way to test the Actions workflow?
(As compared to creating a new branch new_main, merging my feature branch into that, renaming main to old_main, and then renaming new_main to main. And cloning the template repo to manually go through the workflow. And then setting the default repo to be main again. :sweat_smile: )
@mjbear Thank you for submitting this PR! ✨
Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?
I'll get this triaged for review, and the team can address this Q from your linked issue during their review 💛
@mjbear Thank you for submitting this PR! ✨
Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?
I'll get this triaged for review, and the team can address this Q from your linked issue during their review 💛
I've been full of PRs lately :rofl: ... yeah, there's a few others against this repo
@nguyenalex836 If you and your team think the MS Learn article would be good to link to, I will add that modification to this PR and y'all can merge away.
Thank you! :green_heart:
I'm curious to learn of any feedback. Thank you all!
Howdy @mjbear, good to hear from you! 👋 I see this has been assigned to our content team for review - they'll be sure to update you here as soon as they've finished reviewing 💛
We appreciate your patience - thank you so much for contributing to GitHub Skills! ✨