publish-packages icon indicating copy to clipboard operation
publish-packages copied to clipboard

[Feature] Distinguish difference between personal (classic) access tokens and fine-grained access tokens

Open pvcasillasg opened this issue 1 year ago • 4 comments

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Loving this course!

pvcasillasg avatar Jun 03 '24 21:06 pvcasillasg

@pvcasillasg Hello! 👋 Thank you for taking the time to open an issue!

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Can you elaborate more on what you mean here? We're glad you are enjoying the course! ✨

nguyenalex836 avatar Jun 04 '24 18:06 nguyenalex836

@pvcasillasg Hello! 👋 Thank you for taking the time to open an issue!

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Can you elaborate more on what you mean here? We're glad you are enjoying the course! ✨

It's kinda weird, but i have never use a personal access token, and I spend some minutes trying to look for those permisions, so maybe you should update the permissions that requiere to set a fine grainer access token.

or just specify which type of access token are you referring in the step, something like this: Pull Request #43

Just for the most newbies that never did something like that before!

Edit:

The 4th step refer to personal access token but there is two Types of personal access token, which can be a bit confusing

pvcasillasg avatar Jun 04 '24 23:06 pvcasillasg

@pvcasillasg Gotcha! Really appreciate the elaboration here 💛 I'll have the team review this - thanks again for flagging!

nguyenalex836 avatar Jun 04 '24 23:06 nguyenalex836

@pvcasillasg Gotcha! Really appreciate the elaboration here 💛 I'll have the review this - thanks again for flagging!

Thanks to you to take my consideration!

pvcasillasg avatar Jun 04 '24 23:06 pvcasillasg

Based on the written steps and screenshot the only token type that fits is the personal (classic) access tokens. That said the content could call the token type out clearly to eliminate confusion.

mjbear avatar Oct 01 '24 14:10 mjbear

@pvcasillasg I opened up PR #50 to add details. I'm not sure why your PR got closed, but maybe you needed to fork this repo, create changes, and submit a PR against this repo.

@nguyenalex836 @hectorsector This one is in your court now. :laughing: :basketball:

mjbear avatar Oct 01 '24 20:10 mjbear

💟 Thanks so much for the PR @mjbear and for the feedback for all other folks involved.

Based on the written steps and screenshot the only token type that fits is the personal (classic) access tokens. That said the content could call the token type out clearly to eliminate confusion.

I agree with you, here. Although the course could benefit from an update in which type of token is used, we can at least make the steps clearer.

hectorsector avatar Oct 04 '24 18:10 hectorsector

💟 Thanks so much for the PR @mjbear and for the feedback for all other folks involved.

Based on the written steps and screenshot the only token type that fits is the personal (classic) access tokens. That said the content could call the token type out clearly to eliminate confusion.

I agree with you, here. Although the course could benefit from an update in which type of token is used, we can at least make the steps clearer.

Agree, fine grained-tokens are likely the future ... and likely what many of us will prefer to use. :heart:

mjbear avatar Oct 04 '24 22:10 mjbear