egghead-next icon indicating copy to clipboard operation
egghead-next copied to clipboard

Published 20 hours ago • verified publisher icon skillrecordings

chore: Improve the type safety of php-collection-page-layout.tsx

Open Creeland opened this issue 3 years ago • 1 comments

security monitor

Creeland avatar Aug 11 '22 19:08 Creeland

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
egghead-io-nextjs ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 0:56AM (UTC)
egghead-next-storybook ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 0:56AM (UTC)

vercel[bot] avatar Aug 11 '22 19:08 vercel[bot]

It looks like you’re trying to achieve a few different things in this PR:

  1. Upgrade ModuleCollection and LessonLinkResource with better types so that we aren’t just using anys.
  2. Rename NestedResource to ModuleResource (good catch, that’s an improvement!)

After that, I see some reorganization of the structure of the types which seems to be leading to a refactoring of the ResourceCollection JSX. I’m less clear about the “why” on those changes. Am I reading this PR right? Could you say more about what else you’re trying to do?

jbranchaud avatar Aug 13 '22 15:08 jbranchaud

Thanks for this line of discussion Josh.

Stepping back from my fine-grained nits to the broader context of "why?" 💯

joelhooks avatar Aug 13 '22 16:08 joelhooks