JWTMiddleware icon indicating copy to clipboard operation
JWTMiddleware copied to clipboard

Change BasicJWTAuthenticatable usernameKey type

Open Joebayld opened this issue 7 years ago • 2 comments
trafficstars

What are your thoughts on this change:

static var usernameKey: WritableKeyPath<Self, String> { get }

it is currently a KeyPath and not a WritableKeyPath.

This would make it match Vapors BasicAuthenticatable so that my model can conform to PasswordAuthenticatable and BasicJWTAuthenticatable

Joebayld avatar Oct 07 '18 01:10 Joebayld

I like it!

proggeramlug avatar Oct 07 '18 14:10 proggeramlug

Want to submit a PR?

proggeramlug avatar Oct 07 '18 14:10 proggeramlug