skeleton icon indicating copy to clipboard operation
skeleton copied to clipboard

Next: Segment Control component

Open endigo9740 opened this issue 1 year ago • 3 comments

Linked Issue

Closes #2393

Description

Implements the <SegmentControl> and <Segment> components, which which will replace <RadioGroup>.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • [x] This PR targets the dev branch (NEVER master)
  • [x] Documentation reflects all relevant changes
  • [x] Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • [x] Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • [x] Ensure Prettier linting is current - run pnpm format
  • [x] All test cases are passing - run pnpm test
  • [x] Includes a changeset (if relevant; see above)

endigo9740 avatar Jul 01 '24 21:07 endigo9740

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) Jul 8, 2024 6:40pm
skeleton-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
skeleton-themes ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 6:40pm

vercel[bot] avatar Jul 01 '24 21:07 vercel[bot]

🦋 Changeset detected

Latest commit: dad51b8e68ea05d8f5abfd7bff4baa617e9e81fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@skeletonlabs/skeleton-svelte Minor
@skeletonlabs/skeleton-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 01 '24 21:07 changeset-bot[bot]

@eagerestwolf I know we've already asked for a lot from you. But we're introducing a new React component here. I'd appreciate a quick once-over on the React version if you get a chance. No pressure though 👍

endigo9740 avatar Jul 03 '24 19:07 endigo9740

:heavy_check_mark: looks good to me. Seems like you're getting more comfortable with React. It's not too bad once you get the hang of it.

eagerestwolf avatar Jul 07 '24 06:07 eagerestwolf