Remove `reactCompose` utility
Linked Issue
Addresses one issue raised in #2733 (side note: I will from now on open smaller issues, this was just an easy target)
Description
This PR makes 2 notable changes.
- Adds a path alias to
vite.config.ts,tsconfig.json, andtsconfig.package.jsonto redirect the standard alias@to__dirname/src. - All components that rely on composition and previous used the
reactComposefunction, now instead implementObject.assigndirectly.
It's nice to make a small, easy change this time.
Changsets
Changesets have been added. I'll just need to push one more commit to update my message (my mistake, I forgot to follow conventional commit standards).
Checklist
Please read and apply all contribution requirements.
- [x] This PR targets the
devbranch (NEVERmaster) this PR actually targetsnext - [x] Documentation reflects all relevant changes
- [x] Branch is prefixed with:
docs/,feat/,chore/,bugfix/ - [x] Ensure Svelte and Typescript linting is current - run
pnpm ci:check - [x] Ensure Prettier linting is current - run
pnpm format - [x] All test cases are passing - run
pnpm test - [x] Includes a changeset (if relevant; see above)
🦋 Changeset detected
Latest commit: d5e6ff37a0573e24cb3a3d3d346098bb1f595e81
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @skeletonlabs/skeleton-react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| skeleton-docs | ❌ Failed (Inspect) | Jul 8, 2024 6:23pm |
@eagerestwolf is attempting to deploy a commit to the Skeleton Labs Team on Vercel.
A member of the Team first needs to authorize it.
Is this ready to be merged?
@Hugos68 I'm not merging anything this week while I'm out. I'll review all pending PRs when I return next week. I'll let Wolf respond on whether this is ready for review or not.
Yup, everything is done on my end. Whenever Chris comes back from vacation everything is ready to go.
I noticed in a couple of places tailwind classes are being shifted around, this should not be happening, please run format before pushing, I assume this comes from your workspace formatter. (CI still passes because prettier skips everything inside classes)
@eagerestwolf sorry for multiple pings. But wanted to give you a heads up about these incoming updates that may overlap with your efforts here. I did a bit of an overhaul to the React Tabs component, and I may adjust further next week. We the implementation didn't quite match Svelte, but it should be much closer now. I'll plan to finish up and merge this early next week.
- https://github.com/skeletonlabs/skeleton/pull/2748
Also FYI it's a holiday weekend, so I'll be in and out the next few days, but ping me if you need anything. I typically respond most quickly on Discord!
Thanks!
Fixed the Tailwind class order issues, and I added an option to the .vscode/settings.json to not allow Headwind to sort on save (this won't cause any problems if the user doesn't have Headwind installed or it's disabled), as well as adding Headwind to the unwantedExtensions in .vscode/extensions.json. If I missed any classes let me know. I also apologize of the radio silence. I have been incredibly busy with work (we tend to get busy closer to major holidays because I work in the package delivery industry).
@eagerestwolf thanks for the quick turn around. And no worries on the response time. We just wanted to communicate the info, and figured you would respond when possible. If you're ever pressed for time and can't implement changes in a timely manner, just let us know. Communication is key ;)
As per the PR itself, all looks well. Just two minor items of note:
- I went ahead ahead and modified the Changeset to better describe both changes in the PR.
- The exception for Headwind should be fine, but I know you were previously trying to configure Prettier Tailwind as well. So jus for your own purposes - you likely want to commit to one or the other. Mixing the two seems like a bad idea!
That aside, I'm merging this now. Thanks for your contribution! I'll note this PR in the original thread to track overall progress.