skeleton
skeleton copied to clipboard
skeletonlabs
Feat/progress
⚠️ No Changeset found
Latest commit: 3d67114d208a6c7f6f6fd4b82915789092d3e30a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| skeleton-docs | ⬜️ Ignored (Inspect) | Visit Preview | Mar 28, 2024 8:23pm | |
| skeleton-themes | ⬜️ Ignored (Inspect) | Visit Preview | Mar 28, 2024 8:23pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel.
A member of the Team first needs to authorize it.
@Hugos68 similar to the Tabs review, I'll approach this from a few perspectives:
Design
No issues with the design, everything matches my expectations! Great job!
DX
FYI the native <progress> element does not allow a minimum value. I'm not sure it provides any meaningful benefit here since progress should always start a "none". From MDN:
RTL
You can implement simple RTL support using class="-scale-x-[100%]" to mirror (flip) the element on the X-axis. I'd suggest doing this with a rtl: boolean prop. When activated append this to the parent element class list.
Code
Look for my code review comments shortly after this message appears.
@Hugos68 one more note - just noticed a couple merge conflicts. Make sure those are sorted before the next PR review as well. Please and thanks!
@Hugos68 I've completed my review and implemented a few changes.
See all changes in the commit here: https://github.com/skeletonlabs/skeleton/pull/2556/commits/be24ed70d725bb9c062ac1f0b4962466ca5e004a
- Cleaned up the preview page styles (because I have OCD heh)
- Removed any references to
min - Setup RTL demos (I'll follow up regarding animations)
- Extended Tailwind to include
animate-indeterminatevia the Skeleton Tailwind plugin - Renamed
meterIndeterminateAnimtometerAnimateto follow Tailwind convention
The only issue I could not resolve was why the validation error for a value that exceeds a max is not working for me. But if it's working for you I'm not going to stress about it.
I'll follow up in a moment to resolve the merge conflicts.