NBA-Search icon indicating copy to clipboard operation
NBA-Search copied to clipboard

Published 20 hours ago • verified publisher icon skekre98

code duplication in .../modules/scraper.py

Open moki1202 opened this issue 4 years ago • 3 comments

duplication of code from line 336 to line 375

  1. Go to 'modules'
  2. Click on 'scraper.py'
  3. Scroll down to 'line 336 and line 395'
  4. See error (code duplicated)

code

moki1202 avatar Jan 30 '21 08:01 moki1202

Apologies for my absence, I agree the code does not need to be written twice over for advanced and regular stats. If you would like to clean up the code I can go ahead and assign the issue over to you.

skekre98 avatar Apr 13 '21 20:04 skekre98

no worries :) ill do it in a day or two .

moki1202 avatar Apr 13 '21 20:04 moki1202

@skekre98 just noticed that i made a mistake while observing... both the code instances belong to different functions . Do you mean just deleting the "advanced stat " part?

moki1202 avatar Apr 30 '21 11:04 moki1202