endlessh icon indicating copy to clipboard operation
endlessh copied to clipboard

Debian Support

Open DrSkyfaR opened this issue 6 years ago • 14 comments

Hello, I wanted to ask if Debian support is planned?

Greetings Christopher

DrSkyfaR avatar Apr 28 '19 17:04 DrSkyfaR

I don't currently have any plans to make a Debian package for Endlessh, whether official or unofficial. There's an "install" target that follows the standard conventions (CFLAGS, DESTDIR, PREFIX, etc.), so it is already in good shape for packaging in general. For example, with fpm:

$ make clean $ rm -rf destdir $ eval $(dpkg-buildflags --export=sh) $ export PREFIX=/usr $ export DESTDIR=destdir $ make -e install $ fpm -s dir -t deb -n endlessh -v $(git describe) -C destdir .

Note that this wouldn't install the systemd unit file (which can be found under util/) nor would it create a default, editable configuration at /etc/endlessh/config. I'd expect both from a proper Debian package.

skeeto avatar Apr 30 '19 12:04 skeeto

@ApoRes1337 FYI, I'm currently packaging endlessh for Debian.

nicoonoclaste avatar Aug 04 '19 23:08 nicoonoclaste

Update: I uploaded endlessh/1.0-1 an hour ago; it's for now in the NEW queue, awaiting review by the ftp team. After that, it will become available in Debian sid (“unstable”) and, a week later, bullseye (the current “testing”). If there's interest, I could do a backport for buster (the current stable suite, released last month)

nicoonoclaste avatar Aug 05 '19 00:08 nicoonoclaste

Awesome! Thanks, @nbraud! I'm happy about this.

skeeto avatar Aug 07 '19 00:08 skeeto

Any updates on this? I'd love to see and use it from "testing". :)

BenWiederhake avatar Oct 30 '19 14:10 BenWiederhake

For the record:

mxjeff avatar Nov 04 '19 13:11 mxjeff

@nbraud Apologies if this isn't the best way to mention this, but I could not open an issue on the linked GitLab. I'm not very familiar with systemd's inner workings, but my gut tells me the following line

ExecStart=/opt/endlessh/endlessh

should instead be /opt/endlessh/endlessh -f /etc/endlessh/endlessh.conf (for example) and I also see no indication that a default configuration file would be created after install.

Again, this may be due to my lack of understanding of how packages work, but as it stands I don't see how to configure the package as published short of editing the unit file after installation. Please do correct me if I'm wrong.

If I'm not, however, I think it would make for a better user experience if this change was made and a default config was provided, as I know myself and quite a few others who have come to rely on this behavior from other Debian packages.

SeinopSys avatar Dec 28 '19 16:12 SeinopSys

FWIW this has been in unstable for a couple of months now. It appears that it's not migrating further due to:

Not built on buildd: arch amd64 binaries uploaded by nicoo

d7415 avatar Jan 03 '20 23:01 d7415

@SeinopSys The unit file in the package uses the correct binary path (I added a distro-level patch). In the future, please report bugs against the package in Debian's bug tracker, preferably using the command reportbug endlessh. That way:

  • they show up in my Debian Maintainer Dashboard;
  • reportbug already includes useful information (whether you overrode the systemd unit files, which version of the package and its dependencies are installed, ...) ;
  • you get notified automatically (by email) when I upload a new version that fixes your bug.

FYI, you can create a guest account on Salsa.

nicoonoclaste avatar Jan 30 '20 21:01 nicoonoclaste

@BenWiederhake @d7415 Yeap, the release team's policy of requiring binaries built on Debian infrastructure conflicts with the ftp team's policy of requiring binary uploads for NEW (so they can review the built packages). I've already requested a rebuild on amd64, so this should get into testing sometime in February.

nicoonoclaste avatar Jan 30 '20 21:01 nicoonoclaste

Apologies for the reply latency: the package didn't clear NEW until November, at which point I was fairly unavailable (my partner and I had medical complications...)

nicoonoclaste avatar Jan 30 '20 21:01 nicoonoclaste

Update: since @skeeto released v1.1 tonigh, I uploaded it to sid (with urgency=medium, so barring any problem that will arrive in testing in 5 days).

nicoonoclaste avatar Feb 01 '20 04:02 nicoonoclaste

endlessh got into Debian testing today, and I just uploaded a version to buster-backports :tada: I think we can close this issue now :)

nicoonoclaste avatar Feb 06 '20 23:02 nicoonoclaste