react-native-change-icon icon indicating copy to clipboard operation
react-native-change-icon copied to clipboard

fix: replace ICON_INVALID text with original error and fix readme

Open sakshya73 opened this issue 2 years ago • 1 comments

I was trying out this package and faced some issues so I thought to address those.

Issues: Android:

  • I had an error in my AndroidManifest.xml file for the package name but in the log, I was getting "ICON_INVALID". solution - Replace "ICON_INVALID" with the original error.

ios:

  • I wasn't able to change my icon and was constantly getting not able to find changeIcon because I forgot to do pod install as it wasn't mentioned in the docs. solution - added a step for pod install in the docs.

Thanks for this great package :) @skb1129 .

sakshya73 avatar Nov 23 '22 08:11 sakshya73

Could you please look into this PR? @skb1129

sakshya73 avatar Dec 02 '22 17:12 sakshya73

custom error message are a way to standardise error handling, we can't rely on the system error messages for that

skb1129 avatar Aug 18 '23 12:08 skb1129