react-native-change-icon icon indicating copy to clipboard operation
react-native-change-icon copied to clipboard

Crash with new arch enabled

Open dankocher opened this issue 1 year ago • 3 comments

Platform

  • [x] iOS
  • [ ] Android

Description Application crash with new arch enabled

TypeError: Cannot read property 'getIcon' of null

Device (please complete the following information):

  • Device: iPhone 12 Pro
  • OS: iOS 18.2

Versions

  • react-native: 0.76.5
  • react-native-change-icon: 5.0.0

dankocher avatar Dec 16 '24 11:12 dankocher

This should fix it - https://github.com/skb1129/react-native-change-icon/pull/115

mobinni avatar Dec 16 '24 20:12 mobinni

Any progress on this?

dancixx avatar Feb 01 '25 08:02 dancixx

The patch fixes the crash for me, but changing the icon is not working on ios for me

csillaj avatar Feb 04 '25 07:02 csillaj

@skb1129 Any progress on this ? both changeIcon and getIcon not working

Image

ahsanparacha02 avatar Mar 12 '25 19:03 ahsanparacha02

On XCode from Pods > Development Pods > react-native-change-icon open file ChangeIcon.h. Remove all content and add this

#import <UIKit/UIKit.h>

#import <React/RCTBridgeModule.h>
@interface ChangeIcon : NSObject <RCTBridgeModule, UIApplicationDelegate>

@end

dankocher avatar Mar 12 '25 20:03 dankocher

On XCode from Pods > Development Pods > react-native-change-icon open file ChangeIcon.h. Remove all content and add this

#import <UIKit/UIKit.h>

#import <React/RCTBridgeModule.h>
@interface ChangeIcon : NSObject <RCTBridgeModule, UIApplicationDelegate>

@end

Thanks for the solution, it's working fine locally. Should I add the Pods to .gitignore? Is there a way to avoid pushing the Pods for release ipa?

ahsanparacha02 avatar Mar 13 '25 10:03 ahsanparacha02

On XCode from Pods > Development Pods > react-native-change-icon open file ChangeIcon.h. Remove all content and add this

#import <UIKit/UIKit.h>

#import <React/RCTBridgeModule.h>
@interface ChangeIcon : NSObject <RCTBridgeModule, UIApplicationDelegate>

@end

Thanks for the solution, it's working fine locally. Should I add the Pods to .gitignore? Is there a way to avoid pushing the Pods for release ipa?

any solution ?

HcumaliPik avatar Nov 14 '25 12:11 HcumaliPik