react-native-change-icon icon indicating copy to clipboard operation
react-native-change-icon copied to clipboard

SS Adds ability to use unsafe suppress alert option for iOS only

Open NoodleOfDeath opened this issue 1 year ago • 5 comments

Need to

  • [ ] run some tests first, but this allow devs to use the unsafe method that does not force an alert popup.
  • [x] I need to also put it inside of a try catch
  • [x] update android so the code doesnt break

NoodleOfDeath avatar May 18 '24 13:05 NoodleOfDeath

@NoodleOfDeath Thanks for this feature Please add "SS" in this pull request to clarify the "suppress alert option" for others.

bibhuti9 avatar Oct 03 '24 16:10 bibhuti9

@NoodleOfDeath Thanks for this feature Please add "SS" in this pull request to clarify the "suppress alert option" for others.

As the comment? Or in the title? Or both?

NoodleOfDeath avatar Oct 03 '24 19:10 NoodleOfDeath

I mean, it would be great if you could add the feature SS in the PR description.

bibhuti9 avatar Oct 03 '24 19:10 bibhuti9

I mean, it would be great if you could add the feature SS in the PR description.

SS as in a screenshot?

NoodleOfDeath avatar Oct 03 '24 19:10 NoodleOfDeath

The feature just lets you assign the icon without a popup alert... nothing to really to screenshot?

NoodleOfDeath avatar Oct 03 '24 20:10 NoodleOfDeath