react-native-change-icon icon indicating copy to clipboard operation
react-native-change-icon copied to clipboard

[Bonnmh] - [30/01] - hide alert success iOS

Open bonnmh opened this issue 1 year ago • 6 comments

Appstore is completely approved, I think it will help many people

bonnmh avatar Jan 30 '24 08:01 bonnmh

This patch works well

vozaldi avatar Feb 29 '24 06:02 vozaldi

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling? Also, can you please move the React Native reject/resolve function calls to the function you've written?

skb1129 avatar Mar 08 '24 05:03 skb1129

@skb1129

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling? Also, can you please move the React Native reject/resolve function calls to the function you've written?

i think it works as same as this part of code that was before (on error it do nothing without using resolve/reject for RN)

       [[UIApplication sharedApplication] setAlternateIconName:newIconName completionHandler:^(NSError * _Nullable error) {
            return;
        }];

litinskii avatar Mar 19 '24 14:03 litinskii