Martin Skarsaune
Martin Skarsaune
> Ok, so at least in JMC 7.1.0 and 8.3.0 this use to work by the fact that the plugin uses the extension point for JMX protocol: https://github.com/skarsaune/jmc/blob/e2c2275d05ee2e2215ea2a48b720ef2fef456810/application/org.openjdk.jmc.jolokia/plugin.xml#L43 However this...
Update 2: So https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.rjmx.ext/META-INF/services/javax.management.remote.JMXConnectorProvider is not detected by `javax.management.remote.JMXConnectorFactory`' s classloader. I also tried to use `org.openjdk.jmc.rjmx.common.internal.RJMXConnection` 's classloader, but that no longer works as the `.ext` module is not...
@aptmac : I believe I have addressed all comments so far, apart from enabling coverage test (next on my list). Status: Test connection :white_check_mark: Do flight recording :white_check_mark: Open JMX...
@aptmac : I have now upgraded to the latest version of Jolokia (whole new stream) , to make it easier to take advantage of upstream dependencies. In the process I...
I guess another note: The current way to hook the connector into `RJMXConnection` does work, and it was the cleanest way to hook it in that I came up with....
@aptmac : Did you get any time to look at it? I could have a crack at the coverage tests myself, if I could get some pointers or be directed...
> Overall this is looking nice. The tests pass and I was able to connect over Jolokia to the test jvm and verify that the mbean browser & recordings work...
@aptmac : Marked it as ready for review. You may see from the last commits that when I tried to get test coverage it broke the regular test run. Hence...
@aptmac I believe the comments should be addressed now.
@aptmac : Merged in master and added jolokia to 2024-03.